Rare project developers

[Alexander Gall <>]

On Thu, 24 Feb 2022 10:25:50 +0100, Frédéric LOUI <> 
said:

> You can also merge bf_ifcounter, bf_subifcounter and bf_snmp_client thread.
> bf_ifcounter, bf_subifcounter is used to report intf and subintf counters 
> to freeRouter.
> bf_snmp_client exports the same counters to SNMP files.

> The new thread can can to freeRtr unconditionally 

> SNMP export can be exported if « args.snmp » is enabled

> What is your opinion ?

That would certainly simplify things and also avoid that multiple
threads have to maintain their own active_ports table. I'll start
working on that.

-- 
Alex

> After bf_forwarder.py modularisation, you are actually already one step 
> ahead :)

> Thanks for your optimisation proposal.

> If you are OK feel free to apply your code.

>> Le 24 févr. 2022 à 10:10, Alexander Gall <> a écrit :
>> 
>> On Thu, 24 Feb 2022 09:54:00 +0100, Frédéric LOUI 
>> <> said:
>> 
>>> Hi Alex,
>>> Feel free to apply your fix to bf_forwarder.py and the p4 code.
>> 
>>> The place where subintf counters are processed in bf_forwarde.py should 
>>> be _only_  here:
>>> https://bitbucket.software.geant.org/projects/RARE/repos/rare/browse/bfrt_python/rare/bf_subifcounter/__init__.py
>> 
>> Maybe it should, but it obviously isn't :( To avoid duplication of
>> code, I think we'll have to modify the counter modules with an API to
>> share this code with the SNMP module in a thread-safe manner. Other
>> suggestions?
>> 
>> -- 
>> Alex
>>